> On March 3, 2015, 3:31 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 482-483 > > <https://reviews.apache.org/r/31632/diff/1/?file=882291#file882291line482> > > > > Can just do Execute(format("template_string")) and the variables should > > be replaced (test, of course).
Here we have few variables with name version in frame context, so format() function is not applicable (throws an error) > On March 3, 2015, 3:31 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 601 > > <https://reviews.apache.org/r/31632/diff/1/?file=882295#file882295line601> > > > > Just make COMMAND_PARAMS_VERSION = KeyName.VERSION and leave that > > variable for consistency. makes sense - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31632/#review74960 ----------------------------------------------------------- On March 2, 2015, 7:15 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31632/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 7:15 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-9876 > https://issues.apache.org/jira/browse/AMBARI-9876 > > > Repository: ambari > > > Description > ------- > > STR: > Deployed a 3-node cluster with ambari-server rpm 439 > Added HDP 2.2.2.0-2450 with only HDFS and ZK > Enabled NameNode HA > Performed an RU to HDP 2.2.2.0-2485 > Added MR and YARN, which got installed with the old bits (2450) instead of > 2485 > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestScript.py 1d112d8 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 00580c0 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 3d2c622 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 2fca2b3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 2bf0cbf > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9a56e2b > > Diff: https://reviews.apache.org/r/31632/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.973s] > [INFO] Ambari Server ..................................... SUCCESS > [36:32.285s] > [INFO] Ambari Agent ...................................... SUCCESS [16.792s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:52.759s > [INFO] Finished at: Mon Mar 02 21:01:25 EET 2015 > [INFO] Final Memory: 33M/296M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
