> On March 3, 2015, 6:13 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 214 > > <https://reviews.apache.org/r/31632/diff/2/?file=883092#file883092line214> > > > > Perhaps call .lower() before comparison.
At line 176: command_name = str.lower(sys.argv[1]) > On March 3, 2015, 6:13 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 201 > > <https://reviews.apache.org/r/31632/diff/2/?file=883092#file883092line201> > > > > small typo in "form" fixed > On March 3, 2015, 6:13 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 215 > > <https://reviews.apache.org/r/31632/diff/2/?file=883092#file883092line215> > > > > We should generalize the method name, such as set_version, since > > hdp-select is just one method for HDP. fixed > On March 3, 2015, 6:13 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 470 > > <https://reviews.apache.org/r/31632/diff/2/?file=883092#file883092line470> > > > > Is this to avoid circular dependencies? regarding default - yes Moved Execute import higher > On March 3, 2015, 6:13 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 301 > > <https://reviews.apache.org/r/31632/diff/2/?file=883092#file883092line301> > > > > Why is this method now static? Because that is just a utility method - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31632/#review74995 ----------------------------------------------------------- On March 3, 2015, 3:47 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31632/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 3:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-9876 > https://issues.apache.org/jira/browse/AMBARI-9876 > > > Repository: ambari > > > Description > ------- > > STR: > Deployed a 3-node cluster with ambari-server rpm 439 > Added HDP 2.2.2.0-2450 with only HDFS and ZK > Enabled NameNode HA > Performed an RU to HDP 2.2.2.0-2485 > Added MR and YARN, which got installed with the old bits (2450) instead of > 2485 > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestScript.py 1d112d8 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 00580c0 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 3d2c622 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 2fca2b3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > dcbbed2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9a56e2b > > Diff: https://reviews.apache.org/r/31632/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.973s] > [INFO] Ambari Server ..................................... SUCCESS > [36:32.285s] > [INFO] Ambari Agent ...................................... SUCCESS [16.792s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:52.759s > [INFO] Finished at: Mon Mar 02 21:01:25 EET 2015 > [INFO] Final Memory: 33M/296M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
