[ 
https://issues.apache.org/jira/browse/AMBARI-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384101#comment-14384101
 ] 

Hadoop QA commented on AMBARI-4782:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707787/AMBARI-4782.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/2157//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/2157//console

This message is automatically generated.

> Error in getting host components with state INSTALL_FAILED
> ----------------------------------------------------------
>
>                 Key: AMBARI-4782
>                 URL: https://issues.apache.org/jira/browse/AMBARI-4782
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server, test
>    Affects Versions: 1.3.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Vitaly Brodetskyi
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-4782.patch
>
>
> h2. The problem
> When try to get query on 
> api/v1/clusters/<clustername>/host_components?HostRoles/state=INSTALL_FAILED
> Response is
> { "status" : 400, "message" : "Invalid Request: Invalid arguments, invalid 
> desired state, desiredState=INSTALL_FAILED" }
> This issue is rooted at the over all issue Ambari has where when "state" is 
> specified in the API requests it is always interpreted as "desired_state". 
> And INSTALL_FAILED is an invalid "desired_state". Just fixing the GET calls 
> to interpret request:state as "state" (current state of a host component) 
> might be the right thing to do but will make the get calls to behave 
> differently than other calls. For example, request to set all component which 
> are in INSTALL_FAILED state to INIT (or MAINTENANCE) will not work as 
> expected. 
> h2. The proposal:
> The fix is to distinguish between "current_state" and "desired_state" and 
> promote "current_state" as a first class query parameter. "state" query 
> parameter will be still mapped to "desired_state" to maintain backward 
> compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to