[ 
https://issues.apache.org/jira/browse/AMBARI-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387009#comment-14387009
 ] 

Hudson commented on AMBARI-4782:
--------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #2146 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/2146/])
AMBARI-4782. Error in getting host components with state 
INSTALL_FAILED.(vbrodetskyi) (vbrodetskyi: 
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=8c237ec8660ea728b7ec5632fd9ea555d2373d1a)
* 
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
* 
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
* 
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
* 
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* 
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java


> Error in getting host components with state INSTALL_FAILED
> ----------------------------------------------------------
>
>                 Key: AMBARI-4782
>                 URL: https://issues.apache.org/jira/browse/AMBARI-4782
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server, test
>    Affects Versions: 1.3.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Vitaly Brodetskyi
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-4782.patch
>
>
> h2. The problem
> When try to get query on 
> api/v1/clusters/<clustername>/host_components?HostRoles/state=INSTALL_FAILED
> Response is
> { "status" : 400, "message" : "Invalid Request: Invalid arguments, invalid 
> desired state, desiredState=INSTALL_FAILED" }
> This issue is rooted at the over all issue Ambari has where when "state" is 
> specified in the API requests it is always interpreted as "desired_state". 
> And INSTALL_FAILED is an invalid "desired_state". Just fixing the GET calls 
> to interpret request:state as "state" (current state of a host component) 
> might be the right thing to do but will make the get calls to behave 
> differently than other calls. For example, request to set all component which 
> are in INSTALL_FAILED state to INIT (or MAINTENANCE) will not work as 
> expected. 
> h2. The proposal:
> The fix is to distinguish between "current_state" and "desired_state" and 
> promote "current_state" as a first class query parameter. "state" query 
> parameter will be still mapped to "desired_state" to maintain backward 
> compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to