----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32731/#review78552 -----------------------------------------------------------
Please resubmit once unit tests pass. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127400> Should use pythonic_function_names(). ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127401> Replace all prints with logger statements ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127403> This only works on Linux. Please include Jayush and Florian Barca in the code review. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127405> We have methods named checked_call or call that execute processes and also log stdout. Preferable to use them. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127406> Need to import Fail. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32731/#comment127407> May want to add python comments as to why this process needs to be started as root, based on the bug in Linux, and when it can be removed to use HDFS user instead. - Alejandro Fernandez On April 1, 2015, 5:41 p.m., Brandon Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32731/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 5:41 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-10280 > https://issues.apache.org/jira/browse/AMBARI-10280 > > > Repository: ambari > > > Description > ------- > > AMBARI-10280 Need to check if rpcbind or portmap is started before starting > NFS Gateway > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py > e908ecf > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py > 7061057 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py > c7c5325 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 0b9af6b > > Diff: https://reviews.apache.org/r/32731/diff/ > > > Testing > ------- > > Manually tested it on VM. > The python unit test test_nfsgateway.py failed because now NFS is started by > root not hdfs anymore. > > > Thanks, > > Brandon Li > >
