> On April 1, 2015, 5:56 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py, > > line 27 > > <https://reviews.apache.org/r/32731/diff/1/?file=912231#file912231line27> > > > > This only works on Linux. Please include Jayush and Florian Barca in > > the code review.
Windows is not support. A different bug BUG-33975 is to disable NFS Gateway from Ambari UI on Windnows. > On April 1, 2015, 5:56 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py, > > line 31 > > <https://reviews.apache.org/r/32731/diff/1/?file=912231#file912231line31> > > > > We have methods named checked_call or call that execute processes and > > also log stdout. Preferable to use them. Using shell.call now. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32731/#review78552 ----------------------------------------------------------- On April 1, 2015, 5:41 p.m., Brandon Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32731/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 5:41 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-10280 > https://issues.apache.org/jira/browse/AMBARI-10280 > > > Repository: ambari > > > Description > ------- > > AMBARI-10280 Need to check if rpcbind or portmap is started before starting > NFS Gateway > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py > e908ecf > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py > 7061057 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py > c7c5325 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 0b9af6b > > Diff: https://reviews.apache.org/r/32731/diff/ > > > Testing > ------- > > Manually tested it on VM. > The python unit test test_nfsgateway.py failed because now NFS is started by > root not hdfs anymore. > > > Thanks, > > Brandon Li > >
