> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml, > > line 120 > > <https://reviews.apache.org/r/33064/diff/2/?file=923821#file923821line120> > > > > This means we'll need to add Phoenix to the Rolling Upgrade > > orchestration. Take a look at upgrade-2.2.xml to find out where it goes.
I'm not sure what you're thinking here. Before 2.3 there is no query server, so there's nothing to upgrade/bounce. In 2.3, query server is an optional component, so nothing for force install that wasn't there. What does "versionAdvertised" mean? I never found a schema or descriptions for these fields, so I just copied what other HBase components did. Should we just remove this tag? > On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py, > > line 21 > > <https://reviews.apache.org/r/33064/diff/2/?file=923823#file923823line21> > > > > We should use named imports. This makes it easier to find which module > > things come from. Import * is used throughout the code base. > On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, > > line 21 > > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line21> > > > > Use named imports. likewise. > On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, > > line 27 > > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line27> > > > > In a kerberized cluster, will first need to kinit before starting or > > stopping. Is that going to go in this patch or a future one? I've not tested this. Should probably come in this patch. I see no example of this in `hbase_service.py`, is there some other example I can follow? > On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, > > line 40 > > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line40> > > > > Should probably check that the exists first. Why? The -f will silently ignore the lack of file -- it's only there in case the above kill command is run. Normal execution phx_daemon_script will take care of it. - nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33064/#review79777 ----------------------------------------------------------- On April 10, 2015, 1:58 p.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33064/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 1:58 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-9993 > https://issues.apache.org/jira/browse/AMBARI-9993 > > > Repository: ambari > > > Description > ------- > > Per JIRA > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml > 1032024 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 98f0473 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/33064/diff/ > > > Testing > ------- > > > Thanks, > > nick dimiduk > >
