----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33064/#review80235 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml <https://reviews.apache.org/r/33064/#comment130033> Will need to set versionAdvertised to true in a future patch once hdp-select supports it. ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py <https://reviews.apache.org/r/33064/#comment130038> Ideally, use named imports, and it doesn't look like resource_management is being used at all in this script. ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py <https://reviews.apache.org/r/33064/#comment130040> Should import format, Execute, and check_process_status explicitly. ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py <https://reviews.apache.org/r/33064/#comment130042> Nice! ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json <https://reviews.apache.org/r/33064/#comment130043> This is me being nit-picky, but this file does have extraneous things like knox and storm that are not needed and can be removed, but let's do that in a future patch. - Alejandro Fernandez On April 15, 2015, 6:08 p.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33064/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 6:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Yusaku Sako. > > > Bugs: AMBARI-9993 > https://issues.apache.org/jira/browse/AMBARI-9993 > > > Repository: ambari > > > Description > ------- > > Per JIRA > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/33064/diff/ > > > Testing > ------- > > > Thanks, > > nick dimiduk > >
