> On April 14, 2015, 11:51 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java, > > line 455 > > <https://reviews.apache.org/r/33205/diff/1/?file=929520#file929520line455> > > > > I'm skeptical this will work. If not, I'll use raw SQL statements that > > will need to take care of all of the DB types since it's going to need a > > LIMIT clause (which is done differently in each DB type). > > Nate Cole wrote: > You didn't test an actual cluster upgrade with this code to verify?
Sorry, I meant to say "an actual ambari upgrade" - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33205/#review80153 ----------------------------------------------------------- On April 14, 2015, 11:48 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33205/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 11:48 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan > Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-10169 > https://issues.apache.org/jira/browse/AMBARI-10169 > > > Repository: ambari > > > Description > ------- > > As part AMBARI-10167 (Delete a host from Ambari cluster is not clean; fails > to re-add the same host), need all of the host-related tables to switch from > a host_name to a host_id. > This is for the host_version and host_role_command tables. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7447a2d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > f37e937 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactory.java > 1126666 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactoryImpl.java > b63adfa > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 51d5e8a > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageFactoryImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a4ddf14 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 0c5e04a > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 5cd75bb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > e872fe9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9733eff > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > dcc06a7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > f927197 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java > a811c16 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > c9877fb > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 363e6be > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > 4fe3787 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 1a8bf43 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 884032e > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 020dd4b > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c3488f2 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0455e9e > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 2c381b2 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 24762eb > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql adf5828 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > d498c97 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageTest.java > cd424d4 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 112e1e5 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java > 6c5a8a0 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > dd93176 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestStage.java > 7ee6045 > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > f4d9c63 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > c6e2788 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 947a76f > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 3e310ff > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java > d11dae0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 1cc75c7 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 6041066 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > 7cf59e9 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java > 8ca53f7 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java > 580351f > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 87dd18b > > ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java > 0a381f9 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 66a4ade > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java > 7455706 > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java > c411985 > > Diff: https://reviews.apache.org/r/33205/diff/ > > > Testing > ------- > > Local unit tests passed on branch that was based on an older commit. > After rebasing, some unit tests failed, so will fix those and re-test on a > live cluster. > > Refactoring the host_version table was easy. > Doing the same for the host_role_command had a cascading effect since many > classes create stages, and that needed the injector to use HostDAO to do the > lookup. > The UpgradeCatalog210 also had changes, and it specifically has one function > that I need to test during the Ambari upgrade. > > > Thanks, > > Alejandro Fernandez > >
