> On April 18, 2015, 12:18 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, > > line 505 > > <https://reviews.apache.org/r/33205/diff/2/?file=932020#file932020line505> > > > > Kind of interesting; would it be better to pick randomly instead?
It may be useful to make it deterministic. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33205/#review80563 ----------------------------------------------------------- On April 18, 2015, 11:23 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33205/ > ----------------------------------------------------------- > > (Updated April 18, 2015, 11:23 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan > Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-10169 > https://issues.apache.org/jira/browse/AMBARI-10169 > > > Repository: ambari > > > Description > ------- > > As part AMBARI-10167 (Delete a host from Ambari cluster is not clean; fails > to re-add the same host), need all of the host-related tables to switch from > a host_name to a host_id. > This is for the host_version and host_role_command tables. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7447a2d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > f37e937 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactory.java > 1126666 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactoryImpl.java > b63adfa > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 51d5e8a > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageFactoryImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 38c222d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > b2120ab > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 0c5e04a > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 1bb0d0f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > b952c7c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 926d9bb > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > dcc06a7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > 279c78f > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > f927197 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java > c329f24 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > c9877fb > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 5fb024d > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > 4fe3787 > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 9643fe1 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 8897657 > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 020dd4b > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 62a8541 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 436e438 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 252feea > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > d2edab0 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 835c23f > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > ca07938 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageTest.java > cd424d4 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 6a6f75a > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java > 5e20bee > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > dd93176 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestStage.java > 7ee6045 > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > f4d9c63 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 5ae6d5d > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 947a76f > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 0ac1ba4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 1cc9637 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java > d11dae0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 55932db > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 7ffce7e > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > 5ae9f0c > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java > 7ebcdf9 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java > 580351f > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > df65319 > > ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java > 0a381f9 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > bb1cb46 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java > 7455706 > > Diff: https://reviews.apache.org/r/33205/diff/ > > > Testing > ------- > > Local unit tests passed, and tested on a live cluster. I was able to run > commands (affects host_role_command table), add a host (affects host_version > table), and view the cluster versions page (queries host_version table). > Further, I performed an ambari-upgrade from 2.0.0 to 2.1.0 and it did the > Host DDL/DML correctly. > > > Thanks, > > Alejandro Fernandez > >
