> On April 17, 2015, 10:22 p.m., Jayush Luniya wrote: > > @Nick, > > I see that common-services/HBASE/1.1.0.2.3 is mostly a copy of > > common-services/HBASE/0.96.0.2.0. This leads to code duplication. Common > > services supports inheritence. So common-services/HBASE/1.1.0.2.3 can > > inherit from common-services/HBASE/0.96.0.2.0. Although we need to > > duplicate the package folder due to limitation in inheritance model, if we > > inherit, we can get rid off duplicated configs. Also the metainfo.xml is > > merged so you dont need to duplicate the components either. > > Jayush Luniya wrote: > Further there is another issue here. Current inheritance hierarchy is > > common-services/HBASE/0.96.0.2.0 > stacks/HDP/2.0.6/services/HBASE > stacks/HDP/2.1/services/HBASE > stacks/HDP/2.2/services/HBASE > > common-services/HBASE/1.1.0.2.3 > stacks/HDP/2.3/services/HBASE > > This means that any override/new configs that are added in the inherited > stack (ex: stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml) will > not be present in stacks/HDP/2.3/services/HBASE > > This leads to regression in 2.3 stack or we would need to duplicate the > overrides in the stack hierarchy in HDP/2.3 causing maintainence issues. > > Alejandro Fernandez wrote: > I believe this is acceptable and by design. > > Alejandro Fernandez wrote: > HDP 2.2 and GDP 2.3 are allowed to diverge. IMO, having HBASE in common > services with logic like "if HDP 2.2: ... elif HDP 2.3: ..." becomes more > difficult to keep organized due to legacy reasons. Even though the scripts > have a lot of HDP-specific logic, it's still ok to keep them in > common-services, as long as we know which stack version they go against > easily.
@Alejandro, I will discuss with you offline. I second your opinion on "if HDP 2.2: ... elif HDP 2.3: ..." However we should still inherit the services to avoid duplication whereever possible. The root cause of this forking typically is because of lack of inheritance for packages dir, something we will need to solve. - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33064/#review80548 ----------------------------------------------------------- On April 15, 2015, 7:37 p.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33064/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 7:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Yusaku Sako. > > > Bugs: AMBARI-9993 > https://issues.apache.org/jira/browse/AMBARI-9993 > > > Repository: ambari > > > Description > ------- > > Per JIRA > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/33064/diff/ > > > Testing > ------- > > > Thanks, > > nick dimiduk > >
