----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33521/#review81490 -----------------------------------------------------------
Ship it! This looks fine to me, but I'm not very familiar with the DB update code. It would be a good idea to have someone with more experience in DB upgrades in Ambari look at this (maybe Alejandro Fernandez or Jonathan Hurley) as well. ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java <https://reviews.apache.org/r/33521/#comment131864> Minor Issue: the method name is mis-spelled, I would recommend fixing this for the sake of clarity later on. - Robert Nettleton On April 24, 2015, 3:41 p.m., Emil Anca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33521/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 3:41 p.m.) > > > Review request for Ambari, Costel Radulescu, John Speidel, and Robert > Nettleton. > > > Bugs: AMBARI-10665 > https://issues.apache.org/jira/browse/AMBARI-10665 > > > Repository: ambari > > > Description > ------- > > PROBLEM: Request for blueprints will fail with server error 500 following > upgrade from Ambari 1.6.1 to 1.7 > > SOLUTION: Added missing columns > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 6249d2a > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java > 714b6b7 > > Diff: https://reviews.apache.org/r/33521/diff/ > > > Testing > ------- > > mvn clean test > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [6.912s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s] > [INFO] Ambari Web ........................................ SUCCESS [29.655s] > [INFO] Ambari Views ...................................... SUCCESS [1.196s] > [INFO] Ambari Admin View ................................. SUCCESS [19.873s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s] > [INFO] Ambari Server ..................................... SUCCESS [2:39.489s] > [INFO] Ambari Agent ...................................... SUCCESS [9.179s] > [INFO] Ambari Client ..................................... SUCCESS [0.202s] > [INFO] Ambari Python Client .............................. SUCCESS [1.121s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s] > [INFO] Ambari Shell ...................................... SUCCESS [0.108s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.637s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Emil Anca > >
