> On April 30, 2015, 2:22 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java, > > line 518 > > <https://reviews.apache.org/r/33521/diff/3/?file=946159#file946159line518> > > > > In Ambari-DDL-MySQL-CREATE.sql, the types differ in each of the tables, > > > > hostgroup_configuration : config_attributes TEXT > > blueprint_configuration : config_attributes VARCHAR(32000) > > clusterconfig : config_attributes LONGTEXT > > > > In Ambari-DDL-SQLServer-CREATE.sql, similar issues
Ugh. Way to be consistent, right? I think that LONGTEXT needs to be avoided in general for MySQL as it causes performance issues due to how it creates temporary tables on SELECT. TEXT seems pretty safe, but there is no direct mapping between EclipseLink and TEXT as char[] maps to LONGTEXT. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33521/#review82168 ----------------------------------------------------------- On April 30, 2015, 11:02 a.m., Emil Anca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33521/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 11:02 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan > Hurley, John Speidel, Robert Levas, and Robert Nettleton. > > > Bugs: AMBARI-10665 > https://issues.apache.org/jira/browse/AMBARI-10665 > > > Repository: ambari > > > Description > ------- > > PROBLEM: Request for blueprints will fail with server error 500 following > upgrade from Ambari 1.6.1 to 1.7 > > SOLUTION: Added missing columns > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > d6d4567 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java > 377c0f7 > > Diff: https://reviews.apache.org/r/33521/diff/ > > > Testing > ------- > > mvn clean test > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [6.912s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s] > [INFO] Ambari Web ........................................ SUCCESS [29.655s] > [INFO] Ambari Views ...................................... SUCCESS [1.196s] > [INFO] Ambari Admin View ................................. SUCCESS [19.873s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s] > [INFO] Ambari Server ..................................... SUCCESS [2:39.489s] > [INFO] Ambari Agent ...................................... SUCCESS [9.179s] > [INFO] Ambari Client ..................................... SUCCESS [0.202s] > [INFO] Ambari Python Client .............................. SUCCESS [1.121s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s] > [INFO] Ambari Shell ...................................... SUCCESS [0.108s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.637s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Emil Anca > >
