> On May 19, 2015, 10:24 a.m., Nate Cole wrote: > > What's the ultimate goal here? The methods imply you're going down the > > Object serialization route, which I've seen go Very Badly once JDK support > > changes. Maybe we can support a type of InputStream method so that the > > caller decides what to do instead of Ambari?
Thanks for reviewing. The reason that we are doing this is that the Storm team needs to be able to pass a binary as the body. The Ambari URLStreamProvider already had that signature but when we added a URLStreamProvider interface for views we made the body property a String. I'm not sure why, I think it was just an oversight. So, to support the Storm use case we had to add the new signature but couldn't remove the old without breaking existing views. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34382/#review84294 ----------------------------------------------------------- On May 19, 2015, 12:12 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34382/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 12:12 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-11170 > https://issues.apache.org/jira/browse/AMBARI-11170 > > > Repository: ambari > > > Description > ------- > > Add new signatures to the URLStreamProvider methods that take an Object for > the body. The existing methods take a String for the body. Deprecate the > existing methods. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java > d8448b8 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java > 0b81e04 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java > 94f5e86 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java > 4a265e7 > ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java > 0f8367a > ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java > 2b667e4 > > Diff: https://reviews.apache.org/r/34382/diff/ > > > Testing > ------- > > Manual testing. > > New unit tests. > > mvn clean test > > All tests pass. > > > Thanks, > > Tom Beerbower > >
