-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34382/
-----------------------------------------------------------

(Updated May 19, 2015, 6:18 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Update diff as suggested by Nate.  New signature takes InputStream for body.  
Old signatures remain.


Bugs: AMBARI-11170
    https://issues.apache.org/jira/browse/AMBARI-11170


Repository: ambari


Description
-------

Add new signatures to the URLStreamProvider methods that take an Object for the 
body. The existing methods take a String for the body. Deprecate the existing 
methods.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java
 1853021 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java 
89d3f14 
  
ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java
 fe4e180 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
 d8448b8 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
 0b81e04 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/URLStreamProviderTest.java
 ebed4db 
  
ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java
 8ad8889 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
 94f5e86 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java
 4a265e7 
  ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
0f8367a 
  ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java 
2b667e4 

Diff: https://reviews.apache.org/r/34382/diff/


Testing
-------

Manual testing.

New unit tests.

mvn clean test

All tests pass.


Thanks,

Tom Beerbower

Reply via email to