----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36171/#review90361 -----------------------------------------------------------
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py (line 131) <https://reviews.apache.org/r/36171/#comment143384> How do we handle the scenario where user did not specify the build number (or wrong build number), and during first install attempt the version was send back with correct build number. Then in the second attempt Server sends the version with correct build number. - Sumit Mohanty On July 3, 2015, 6:14 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36171/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 6:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-12278 > https://issues.apache.org/jira/browse/AMBARI-12278 > > > Repository: ambari > > > Description > ------- > > 2015-07-01 08:07:10,323 - Failure while computing actual version. Error: > Could not determine actual version. This stack's root directory (/usr/hdp) > exists but was not able to determine the actual repository version installed. > Try reinstalling packages again. > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 299, in install_packages > self.compute_actual_version() > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 254, in compute_actual_version > raise Fail(msg) > Fail: Could not determine actual version. This stack's root directory > (/usr/hdp) exists but was not able to determine the actual repository version > installed. Try reinstalling packages again. > Traceback (most recent call last): > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py > 5fdc35d > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b028852 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 1e6dcea > > Diff: https://reviews.apache.org/r/36171/diff/ > > > Testing > ------- > > Patch should be good, but since I performed major refactor and moved methods, > I'd like to perform E2E live test as well. > > Please look through test cases, maybe I forgot something or it should behave > differently in some situations. > > > OK > ---------------------------------------------------------------------- > Total run:796 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
