----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36171/#review90574 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (lines 95 - 97) <https://reviews.apache.org/r/36171/#comment143677> Make a new .py for this. And can it be a ambari.ini config somehow instead of a hard-coded location? ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (lines 223 - 231) <https://reviews.apache.org/r/36171/#comment143674> I'm ok with this in hdp_select.py, since it's hdp-select ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (line 234) <https://reviews.apache.org/r/36171/#comment143676> But read and write and of that REPO_VERSION_HISTORY_FILE should be in a different .py file. And probably made thread-safe, just in case. ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (lines 242 - 250) <https://reviews.apache.org/r/36171/#comment143673> Isn't this file just json to parse and read? If it's not, it should be since we can have multiple versions installed. - Nate Cole On July 6, 2015, 1:06 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36171/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 1:06 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-12278 > https://issues.apache.org/jira/browse/AMBARI-12278 > > > Repository: ambari > > > Description > ------- > > 2015-07-01 08:07:10,323 - Failure while computing actual version. Error: > Could not determine actual version. This stack's root directory (/usr/hdp) > exists but was not able to determine the actual repository version installed. > Try reinstalling packages again. > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 299, in install_packages > self.compute_actual_version() > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 254, in compute_actual_version > raise Fail(msg) > Fail: Could not determine actual version. This stack's root directory > (/usr/hdp) exists but was not able to determine the actual repository version > installed. Try reinstalling packages again. > Traceback (most recent call last): > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py > 5fdc35d > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b028852 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 1e6dcea > > Diff: https://reviews.apache.org/r/36171/diff/ > > > Testing > ------- > > Performed E2E tests > > > OK > ---------------------------------------------------------------------- > Total run:796 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
