> On July 6, 2015, 10:42 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 234 > > <https://reviews.apache.org/r/36171/diff/2/?file=1000311#file1000311line234> > > > > Only one install command should be running at a time on a host. Since > > multiple processes can open the file for reading/writing, we need to make > > sure that we handle IOError gracefully, perhaps surround it with a retry > > decorator.
Ambari architecture does not support running few "install packages" actions in parallel, and this file is used only from install_packages.py. So I don't think the situation when multiple processes open the file for reading/writing is possible. - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36171/#review90595 ----------------------------------------------------------- On July 6, 2015, 5:06 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36171/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 5:06 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-12278 > https://issues.apache.org/jira/browse/AMBARI-12278 > > > Repository: ambari > > > Description > ------- > > 2015-07-01 08:07:10,323 - Failure while computing actual version. Error: > Could not determine actual version. This stack's root directory (/usr/hdp) > exists but was not able to determine the actual repository version installed. > Try reinstalling packages again. > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 299, in install_packages > self.compute_actual_version() > File > "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", > line 254, in compute_actual_version > raise Fail(msg) > Fail: Could not determine actual version. This stack's root directory > (/usr/hdp) exists but was not able to determine the actual repository version > installed. Try reinstalling packages again. > Traceback (most recent call last): > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py > 5fdc35d > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b028852 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 1e6dcea > > Diff: https://reviews.apache.org/r/36171/diff/ > > > Testing > ------- > > Performed E2E tests > > > OK > ---------------------------------------------------------------------- > Total run:796 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
