----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36283/#review90849 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On July 7, 2015, 10:50 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36283/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 10:50 p.m.) > > > Review request for Ambari, Nate Cole and Robert Levas. > > > Bugs: AMBARI-12319 > https://issues.apache.org/jira/browse/AMBARI-12319 > > > Repository: ambari > > > Description > ------- > > Error setting up a Hive view instance. > > The underlying issue is this ... > > > Exception [EclipseLink-4002] (Eclipse Persistence Services - > 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException > Internal Exception: > com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Row size too > large. The maximum row size for the used table type, not counting BLOBs, is > 65535. You have to change some columns to TEXT or BLOBs > Error Code: 1118 > Call: CREATE TABLE DS_JOBIMPL_6 (DS_id VARCHAR(255) NOT NULL, > DS_applicationId VARCHAR(4000), DS_confFile VARCHAR(4000), DS_dagId > VARCHAR(4000), DS_dagName VARCHAR(4000), DS_dataBase VARCHAR(4000), > DS_dateSubmitted BIGINT, DS_duration BIGINT, DS_forcedContent VARCHAR(4000), > DS_globalSettings VARCHAR(4000), DS_logFile VARCHAR(4000), DS_owner > VARCHAR(4000), DS_queryFile VARCHAR(4000), DS_queryId VARCHAR(4000), > DS_referrer VARCHAR(4000), DS_sessionTag VARCHAR(4000), DS_sqlState > VARCHAR(4000), DS_status VARCHAR(4000), DS_statusDir VARCHAR(4000), > DS_statusMessage VARCHAR(4000), DS_title VARCHAR(4000), PRIMARY KEY (DS_id)) > Query: DataModifyQuery(sql="CREATE TABLE DS_JOBIMPL_6 (DS_id VARCHAR(255) NOT > NULL, DS_applicationId VARCHAR(4000), DS_confFile VARCHAR(4000), DS_dagId > VARCHAR(4000), DS_dagName VARCHAR(4000), DS_dataBase VARCHAR(4000), > DS_dateSubmitted BIGINT, DS_duration BIGINT, DS_forcedContent VARCHAR(4000), > DS_globalSettings VARCHAR(4000), DS_logFile VARCHAR(4000), DS_owner > VARCHAR(4000), DS_queryFile VARCHAR(4000), DS_queryId VARCHAR(4000), > DS_referrer VARCHAR(4000), DS_sessionTag VARCHAR(4000), DS_sqlState > VARCHAR(4000), DS_status VARCHAR(4000), DS_statusDir VARCHAR(4000), > DS_statusMessage VARCHAR(4000), DS_title VARCHAR(4000), PRIMARY KEY (DS_id))") > > > Unfortunately, the org.eclipse.persistence.tools.schemaframework makes the > assumption that if an exception is thrown during table creation it just means > that the table already exists and it is ignored. > > Need to see if there is a way to surface these exceptions and to adjust the > default column size so that we don't exceed the MySQL total row size limit. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java > 6d31a08 > > ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java > 1b4758d > > Diff: https://reviews.apache.org/r/36283/diff/ > > > Testing > ------- > > Manual tested. > > Added new unit test. > > mvn clean test > > results pending... > > > Thanks, > > Tom Beerbower > >
