> On July 23, 2015, 4:29 p.m., Jayush Luniya wrote: > >
These and the subsequent items in ambari-server/pom.xml were the result of a bad merge since I had to recreate the patch file after it became stale. > On July 23, 2015, 4:29 p.m., Jayush Luniya wrote: > > File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch > > <https://reviews.apache.org/r/35844/#fcomment77> > > > > Why do we need to make this class public? If I recall, the test would not run after updating the dependencies unless it was public. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35844/#review92828 ----------------------------------------------------------- On July 23, 2015, 1:48 p.m., Jonathan Halterman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35844/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 1:48 p.m.) > > > Review request for Ambari, Jayush Luniya, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-12134 > https://issues.apache.org/jira/browse/AMBARI-12134 > > > Repository: ambari > > > Description > ------- > > The ambari parent pom is targeted towards Java 1.6 while ambari uses 1.7 > APIs. The ambari metrics pom is targeted at java 1.5 (by default) while > ambari-metrics uses 1.6 APIs. This causes basic compilation failures, > depending on how you build the projects and what tools you use to work on > them. AFAIK Ambari 2.1 and beyond are targeted at 1.7, so the Java versions > in the POMs should be updated to reflect this. > > Aside from changing the target version for the compiler plugin, some other > dependencies had to be updated to more recent versions that support 1.7 > compilation. > > > Diffs > ----- > > ambari-metrics/pom.xml b4f4ed3 > pom.xml 47eac31 > > Diff: https://reviews.apache.org/r/35844/diff/ > > > Testing > ------- > > All tests pass! > > > File Attachments > ---------------- > > AMBARI-12134-5.patch > > https://reviews.apache.org/media/uploaded/files/2015/07/23/64a89068-aa27-4e37-b61d-f37e2aeed706__AMBARI-12134-5.patch > > > Thanks, > > Jonathan Halterman > >
