----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35844/#review93042 -----------------------------------------------------------
Ship it! Verified on Mac mvn clean test [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Ambari Main ....................................... SUCCESS [3.251s] [INFO] Apache Ambari Project POM ......................... SUCCESS [0.031s] [INFO] Ambari Web ........................................ SUCCESS [36.674s] [INFO] Ambari Views ...................................... SUCCESS [2.536s] [INFO] Ambari Admin View ................................. SUCCESS [9.583s] [INFO] ambari-metrics .................................... SUCCESS [0.274s] [INFO] Ambari Metrics Common ............................. SUCCESS [1.298s] [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.973s] [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.645s] [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [2.952s] [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.262s] [INFO] Ambari Metrics Collector .......................... SUCCESS [6:20.949s] [INFO] Ambari Metrics Monitor ............................ SUCCESS [1.924s] [INFO] Ambari Metrics Assembly ........................... SUCCESS [3:03.988s] [INFO] Ambari Server ..................................... SUCCESS [48:39.989s] [INFO] Ambari Agent ...................................... SUCCESS [9.282s] [INFO] Ambari Client ..................................... SUCCESS [0.030s] [INFO] Ambari Python Client .............................. SUCCESS [0.353s] [INFO] Ambari Groovy Client .............................. SUCCESS [10.509s] [INFO] Ambari Shell ...................................... SUCCESS [0.029s] [INFO] Ambari Python Shell ............................... SUCCESS [0.037s] [INFO] Ambari Groovy Shell ............................... SUCCESS [7.165s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 59:37.625s [INFO] Finished at: Sun Jul 26 06:30:14 PDT 2015 [INFO] Final Memory: 100M/1079M [INFO] ------------------------------------------------------------------------ - Jayush Luniya On July 25, 2015, 3:45 p.m., Jonathan Halterman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35844/ > ----------------------------------------------------------- > > (Updated July 25, 2015, 3:45 p.m.) > > > Review request for Ambari, Jayush Luniya, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-12134 > https://issues.apache.org/jira/browse/AMBARI-12134 > > > Repository: ambari > > > Description > ------- > > The ambari parent pom is targeted towards Java 1.6 while ambari uses 1.7 > APIs. The ambari metrics pom is targeted at java 1.5 (by default) while > ambari-metrics uses 1.6 APIs. This causes basic compilation failures, > depending on how you build the projects and what tools you use to work on > them. AFAIK Ambari 2.1 and beyond are targeted at 1.7, so the Java versions > in the POMs should be updated to reflect this. > > Aside from changing the target version for the compiler plugin, some other > dependencies had to be updated to more recent versions that support 1.7 > compilation. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-flume-sink/pom.xml 01c2c7f > ambari-metrics/ambari-metrics-kafka-sink/pom.xml adb655b > ambari-metrics/ambari-metrics-storm-sink/pom.xml c4bc676 > ambari-metrics/ambari-metrics-timelineservice/pom.xml 999005a > ambari-metrics/pom.xml b4f4ed3 > ambari-project/pom.xml 0913bff > ambari-server/pom.xml 717d331 > > ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java > ba8f01e > ambari-shell/ambari-groovy-shell/pom.xml 7d2f6da > contrib/views/hive/pom.xml 6a8a392 > pom.xml ffb4d84 > > Diff: https://reviews.apache.org/r/35844/diff/ > > > Testing > ------- > > All tests pass! > > > File Attachments > ---------------- > > AMBARI-12134-6.patch > > https://reviews.apache.org/media/uploaded/files/2015/07/24/8526aa86-3aa4-4fa3-8316-91dec4a1adca__AMBARI-12134-6.patch > > > Thanks, > > Jonathan Halterman > >
