----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37262/#review94666 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Aug. 9, 2015, 12:54 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37262/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 12:54 a.m.) > > > Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-12684 > https://issues.apache.org/jira/browse/AMBARI-12684 > > > Repository: ambari > > > Description > ------- > > As part of this ticket css order of concatenation is set in a way that if > following files are dropped at build time, they will be the last to get > concatenated making selectors defined in them override any ambari css > selector: > # *custom-ui.less* file should be dropped in *ambari/ambari-web/app/styles/* > directory > # *custom-admin-ui.css* file should be dropped in > *ambari-admin/src/main/resources/ui/admin-web/app/styles/* directory > > Since all the CSS related attributes are defined in the stylesheets and not > in html/templates in ambari, This gives an ability to override the look and > feel of ambari and ambari-admin view by simply dropping stylesheet with > desired changes as pointed above. > > NOTE: Since ambari uses RAT plugin in its maven build, these stylesheets > being dropped before compilation should have apache header or else maven > build will fail complaining about missing apache license > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/gulpfile.js a4339b2 > ambari-admin/src/main/resources/ui/admin-web/package.json 2f49d00 > ambari-web/config.coffee 580f05a > > Diff: https://reviews.apache.org/r/37262/diff/ > > > Testing > ------- > > # Tested on a live cluster by dropping files and building ambari-web and > ambari-admin which resulted into different color for header. > # Verified that all ambari-web and ambari-admin unit tests passess > > > Thanks, > > Jaimin Jetly > >
