----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37946/#review97443 -----------------------------------------------------------
I'm a bit confused as to why we need to verify that creation of a repository needs to have an upgrade pack. For things like patch upgrades, there won't be an upgrade pack, but a new repository will be created. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java (line 129) <https://reviews.apache.org/r/37946/#comment153323> Should not need this in this resource provider. (See comment below) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java (lines 158 - 163) <https://reviews.apache.org/r/37946/#comment153319> Indentation fix. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java (lines 359 - 360) <https://reviews.apache.org/r/37946/#comment153320> StackStack? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java (lines 423 - 425) <https://reviews.apache.org/r/37946/#comment153322> Why iterate over all clusters? You have the cluster name from the request. - Jonathan Hurley On Aug. 31, 2015, 9:54 a.m., Dmytro Grinenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37946/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 9:54 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-12934 > https://issues.apache.org/jira/browse/AMBARI-12934 > > > Repository: ambari > > > Description > ------- > > In Ambari 2.2.0, we'll need to support Stop-and-Start Upgrade from HDP 2.x -> > 2.y. > This means that if the user is still on HDP 2.x, the only upgrade pack > possible will be Stop-and-Start Upgrade to HDP 2.y, so it doesn't make sense > to allow the user to register a repo for any version except HDP 2.y. > During repo_version creation, we need to ensure that the version being > installed has an upgrade pack that will allow upgrading to it. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > f1fa3bf > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 79b8eb5 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java > 2e17cf4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 442bcb2 > > Diff: https://reviews.apache.org/r/37946/diff/ > > > Testing > ------- > > tests passed > > > Thanks, > > Dmytro Grinenko > >
