> On Sept. 2, 2015, 9:37 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, > > lines 424-426 > > <https://reviews.apache.org/r/37946/diff/1/?file=1060284#file1060284line424> > > > > Why iterate over all clusters? You have the cluster name from the > > request. > > Dmytro Grinenko wrote: > No, not this time! Below is the full dump of the request > > Request:, propertyIds=[ ], properties=[ { > propertyName=operating_systems, > propertyValue=[{repositories=[{Repositories/repo_id=HDP-2.3, > Repositories/base_url=http://xxxxxx, Repositories/repo_name=HDP}, > {Repositories/repo_id=xxxxxx, Repositories/base_url=xxxxxxxx, > Repositories/repo_name=xxxxxx}], OperatingSystems/os_type=redhat6}] }, { > propertyName=RepositoryVersions/stack_name, propertyValue=HDP }, { > propertyName=RepositoryVersions/id, propertyValue=NULL }, { > propertyName=RepositoryVersions/repository_version, propertyValue=xxxxxx }, > { propertyName=RepositoryVersions/display_name, propertyValue=xxxxxx }, { > propertyName=RepositoryVersions/stack_version, propertyValue=2.3 }, ], > temporalInfo=[null ]
Ah, right! I forgot that we don't always have it here. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37946/#review97443 ----------------------------------------------------------- On Sept. 3, 2015, 1:14 a.m., Dmytro Grinenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37946/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 1:14 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-12934 > https://issues.apache.org/jira/browse/AMBARI-12934 > > > Repository: ambari > > > Description > ------- > > In Ambari 2.2.0, we'll need to support Stop-and-Start Upgrade from HDP 2.x -> > 2.y. > This means that if the user is still on HDP 2.x, the only upgrade pack > possible will be Stop-and-Start Upgrade to HDP 2.y, so it doesn't make sense > to allow the user to register a repo for any version except HDP 2.y. > During repo_version creation, we need to ensure that the version being > installed has an upgrade pack that will allow upgrading to it. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > f1fa3bf > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 79b8eb5 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java > 2e17cf4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 442bcb2 > > Diff: https://reviews.apache.org/r/37946/diff/ > > > Testing > ------- > > tests passed > > > Thanks, > > Dmytro Grinenko > >
