----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38196/#review98229 -----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 340) <https://reviews.apache.org/r/38196/#comment154526> Should probably first check that input is not null or empty, and same after splitting. ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 349) <https://reviews.apache.org/r/38196/#comment154528> This assumes that at least one point was written. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py (line 38) <https://reviews.apache.org/r/38196/#comment154529> use pythonic function names in formatXmxSizeToBytes ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py (line 52) <https://reviews.apache.org/r/38196/#comment154534> For performance reasons, initialize these instead of multiplying every time (and can calulate using previous size indicator to avoid additional computations). m should be outside of the function since not specific to the input. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py (line 56) <https://reviews.apache.org/r/38196/#comment154530> Add PyDoc ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py (line 98) <https://reviews.apache.org/r/38196/#comment154531> Exception handler returns -1, but other code paths don't return an integer. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py (line 155) <https://reviews.apache.org/r/38196/#comment154533> All code paths need to return a value. - Alejandro Fernandez On Sept. 9, 2015, 1:23 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38196/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 1:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, > Myroslav Papirkovskyy, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-13039 > https://issues.apache.org/jira/browse/AMBARI-13039 > > > Repository: ambari > > > Description > ------- > > - In light of AMBARI-12983, performance would be seen if the precision table > can fully utilize the allocated memstore heap. > - With the single table getting most of the high volume reads and all of the > high volume writes it is important to define a policy for splitting the > Region in order to optimize performance of the scans. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 1bd20a3 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > d70d77d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > fa30e19 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/AMBARI_METRICS.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/FLUME.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HBASE.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HDFS.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HOST.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/KAFKA.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/STORM.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/YARN.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/38196/diff/ > > > Testing > ------- > > Unit test pass. > Manual testing in progress. > > > Thanks, > > Sid Wagle > >
