> On Sept. 9, 2015, 5:50 p.m., Alejandro Fernandez wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java, > > line 340 > > <https://reviews.apache.org/r/38196/diff/1/?file=1065717#file1065717line340> > > > > Should probably first check that input is not null or empty, and same > > after splitting.
Fixed. > On Sept. 9, 2015, 5:50 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py, > > line 38 > > <https://reviews.apache.org/r/38196/diff/1/?file=1065728#file1065728line38> > > > > use pythonic function names in > > formatXmxSizeToBytes Fixed. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38196/#review98229 ----------------------------------------------------------- On Sept. 9, 2015, 7:56 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38196/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 7:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, > Myroslav Papirkovskyy, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-13039 > https://issues.apache.org/jira/browse/AMBARI-13039 > > > Repository: ambari > > > Description > ------- > > - In light of AMBARI-12983, performance would be seen if the precision table > can fully utilize the allocated memstore heap. > - With the single table getting most of the high volume reads and all of the > high volume writes it is important to define a policy for splitting the > Region in order to optimize performance of the scans. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 1bd20a3 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > d70d77d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > fa30e19 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/AMBARI_METRICS.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/FLUME.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HBASE.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HDFS.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HOST.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/KAFKA.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/STORM.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/YARN.txt > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/38196/diff/ > > > Testing > ------- > > Unit test pass. > Verfied region splits occur as expected. > > > Thanks, > > Sid Wagle > >
