-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 2:52 p.m.)


Review request for Ambari, Jonathan Hurley and Robert Nettleton.


Changes
-------

I suggest that: disable caching by default. It's hard to say what are the 
correct cach size values, because mostly its based on JVM memory, in case of 
someone want to boost database performance, just enable it and set these new 
values (if caching is enabled by default and someone not statisfied with the db 
performance it is still needed to reset these properties)


Bugs: AMBARI-13036
    https://issues.apache.org/jira/browse/AMBARI-13036


Repository: ambari


Description
-------

Problem: 

Ambari does not cache database statements which leads to excessive parsing.

Solution:

Added internal and external statement caching feature to Ambari. Caching used 
by default


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 e3686ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 a40fae6 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 074fbb4 

Diff: https://reviews.apache.org/r/38487/diff/


Testing
-------

Unit testing done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:31 h
[INFO] Finished at: 2015-09-17T17:21:55+00:00
[INFO] Final Memory: 48M/605M
[INFO] ------------------------------------------------------------------------

Functional testing:
Locally: done on Postgres & MySQL databases


Thanks,

Oliver Szabo

Reply via email to