> On Sept. 23, 2015, 8:01 p.m., Jonathan Hurley wrote: > > I'm also torn about the defaults and whether to have them enabled. I think > > that cached statements can lead to negative performance gains in some > > scenarios but in most scenarios will have a positive impact. With that > > said, we really don't have any basis for defaults or correctly tuned values > > without performing some tests with the values off and then on. So, I guess > > we'll leave them off for now and can recommend on how they can be enabled > > if necessary. > > > > I really would like to see a performance benchmark done comparing the off > > and on values on a small and large Ambari deployment.
Ditto, we should be very careful with JDBC settings and test them especially on Oracle and Postgres. +1 if we can get some benchmarks on this and no degredation of performance. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38487/#review100273 ----------------------------------------------------------- On Sept. 23, 2015, 2:52 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38487/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 2:52 p.m.) > > > Review request for Ambari, Jonathan Hurley and Robert Nettleton. > > > Bugs: AMBARI-13036 > https://issues.apache.org/jira/browse/AMBARI-13036 > > > Repository: ambari > > > Description > ------- > > Problem: > > Ambari does not cache database statements which leads to excessive parsing. > > Solution: > > Added internal and external statement caching feature to Ambari. Caching used > by default > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > e3686ac > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > a40fae6 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 074fbb4 > > Diff: https://reviews.apache.org/r/38487/diff/ > > > Testing > ------- > > Unit testing done. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:31 h > [INFO] Finished at: 2015-09-17T17:21:55+00:00 > [INFO] Final Memory: 48M/605M > [INFO] > ------------------------------------------------------------------------ > > Functional testing: > Locally: done on Postgres & MySQL databases > > > Thanks, > > Oliver Szabo > >
