> On Жов. 7, 2015, 4:10 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java, > > line 156 > > <https://reviews.apache.org/r/39052/diff/2/?file=1092321#file1092321line156> > > > > My concern is that this is over-writing hbase-env content property and > > wipe-out changes by users if there are any.
Yes, it will rewrite habse-env. But 1) User will have hbase-env backup. So, it will help him. 2) We don't have a tool which can help us to merge changes. And it will be hard to create such tool because *-env configs can be changed bu Users. So, till now we are updating "content" property in that way. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39052/#review101775 ----------------------------------------------------------- On Жов. 7, 2015, 4:14 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39052/ > ----------------------------------------------------------- > > (Updated Жов. 7, 2015, 4:14 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav > Papirkovskyy, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13325 > https://issues.apache.org/jira/browse/AMBARI-13325 > > > Repository: ambari > > > Description > ------- > > PROBLEM: Ambari update the below setting in hbase-site: > hbase.bucketcache.ioengine=offheap > hbase.bucketcache.percentage.in.combinedcache= > hbase.bucketcache.size=10240 > But there is no setting in hbase-env for > -XX:MaxDirectMemorySize > so when restart HBase Region server, it fails > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 62c3b61 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 62cd868 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > dcdbb85 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > a54dee2 > > Diff: https://reviews.apache.org/r/39052/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
