----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39052/#review101789 -----------------------------------------------------------
Ship it! ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java (line 161) <https://reviews.apache.org/r/39052/#comment159279> It would be better to not limit call count of such mocks since it makes test more fragile without adding on test quality. - Dmitro Lisnichenko On Oct. 7, 2015, 4:14 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39052/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 4:14 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav > Papirkovskyy, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13325 > https://issues.apache.org/jira/browse/AMBARI-13325 > > > Repository: ambari > > > Description > ------- > > PROBLEM: Ambari update the below setting in hbase-site: > hbase.bucketcache.ioengine=offheap > hbase.bucketcache.percentage.in.combinedcache= > hbase.bucketcache.size=10240 > But there is no setting in hbase-env for > -XX:MaxDirectMemorySize > so when restart HBase Region server, it fails > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 62c3b61 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 62cd868 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > dcdbb85 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > a54dee2 > > Diff: https://reviews.apache.org/r/39052/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
