> On Oct. 7, 2015, 4:34 p.m., Jaimin Jetly wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml, > > line 371 > > <https://reviews.apache.org/r/38916/diff/1/?file=1088260#file1088260line371> > > > > Instead of using a macro, The logic should be made part of stack > > advisor and we should keep using absolute value for the property for > > following reasons: > > * we can gracefully handle upgrade scenario. > > * We can use Service config version feature on ambari-web to compare > > it's actual absolute value with previous ones when needed
Jaimin, i think stack advisor wont help here since the requirement here is to derive the host name from the info already available from Ambari (the host where Ranger UserSync is running) and prefill it. Ideally we should leave it blank, but since we have the feature of Macros, we can use it here. If we use stack advisor, 1] User will have to fill this value for each installation 2] If user decides to run against a different host, the stack advisor popup will come for each save asking user to use the host where its installed. - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38916/#review101782 ----------------------------------------------------------- On Oct. 1, 2015, 6:50 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38916/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 6:50 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako. > > > Bugs: AMBARI-13273 > https://issues.apache.org/jira/browse/AMBARI-13273 > > > Repository: ambari > > > Description > ------- > > Patch contains changes on ambari stacks to allow Ranger Usersync to be > installed on separate host. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 7c69e57 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py > 85ac6f5 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 77e487f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml > 7423e8d > > Diff: https://reviews.apache.org/r/38916/diff/ > > > Testing > ------- > > Unit test report: > ---------------------------------------------------------------------- > Ran 264 tests in 8.125s > > OK > ---------------------------------------------------------------------- > Total run:838 > Total errors:0 > Total failures:0 > OK > > Process finished with exit code 0 > > > Thanks, > > Gautam Borad > >
