> On Oct. 7, 2015, 5:07 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 88 > > <https://reviews.apache.org/r/38916/diff/1/?file=1088257#file1088257line88> > > > > We should be careful here and only access an index in an array if we > > check that the array exists.
Changes available in latest patch - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38916/#review101794 ----------------------------------------------------------- On Oct. 8, 2015, 1:04 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38916/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 1:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako. > > > Bugs: AMBARI-13273 > https://issues.apache.org/jira/browse/AMBARI-13273 > > > Repository: ambari > > > Description > ------- > > Patch contains changes on ambari stacks to allow Ranger Usersync to be > installed on separate host. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 7c69e57 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py > 85ac6f5 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 77e487f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml > 96d6147 > > ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json > 2a40a46 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json > f39df97 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json > 9bb1833 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json > c04bdd1 > > ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json > 977749c > > Diff: https://reviews.apache.org/r/38916/diff/ > > > Testing > ------- > > Unit test report: > ---------------------------------------------------------------------- > Ran 264 tests in 8.125s > > OK > ---------------------------------------------------------------------- > Total run:838 > Total errors:0 > Total failures:0 > OK > > Process finished with exit code 0 > > > Thanks, > > Gautam Borad > >
