----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40373/#review106850 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java (lines 423 - 424) <https://reviews.apache.org/r/40373/#comment165659> We don't need to do this anymore in installFactories(). The ResourceProviderFactory.class is no longer required for resource providers. I think the idea at one time was to use Guice to load all the resource providers, but it didn't work like that after we got more than 4 or 5 providers. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java (lines 93 - 95) <https://reviews.apache.org/r/40373/#comment165660> Can use @StaticallyInject on the class and make this static (or a Provider<PermissionDAO>) - Nate Cole On Nov. 17, 2015, 10:04 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40373/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 10:04 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and > Sumit Mohanty. > > > Bugs: AMBARI-13916 > https://issues.apache.org/jira/browse/AMBARI-13916 > > > Repository: ambari > > > Description > ------- > > Create API entry points for getting authorization information. > > The following entry points need to be created: > ``` > GET /api/v1/authorizations > GET /api/v1/permissions/:PERMISSION_ID/authorizations > GET /api/v1/users/:USERNAME/authorizations > ``` > > The following entry points need to be updated to supply more information: > ``` > GET /api/v1/permissions/:PERMISSION_ID > ``` > > # Note: The data layer is stubbed out and left for implementation in > AMBARI-13865 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/PermissionResourceDefinition.java > 56127b9 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > e7bbec4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PermissionService.java > 594caba > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RoleAuthorizationService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java > 05ee6b1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 823ac8a > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > 0979298 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 0310fdc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > fbbc7c8 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/PermissionResourceDefinitionTest.java > 0ad3b47 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java > 081a6eb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java > ebe9b93 > > Diff: https://reviews.apache.org/r/40373/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PASSED > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
