> On Nov. 17, 2015, 1:55 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RoleAuthorizationService.java, > > line 36 > > <https://reviews.apache.org/r/40373/diff/4/?file=1128691#file1128691line36> > > > > Documentation.
I'll add this to the followup patch where I add the data layer. > On Nov. 17, 2015, 1:55 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java, > > line 35 > > <https://reviews.apache.org/r/40373/diff/4/?file=1128692#file1128692line35> > > > > Documentation. I'll add this to the followup patch where I add the data layer. > On Nov. 17, 2015, 1:55 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java, > > line 211 > > <https://reviews.apache.org/r/40373/diff/4/?file=1128695#file1128695line211> > > > > Would you ever need to expose constants like "VIEW.USE" ? If so, better > > to do it now than go back later since you might miss stuff. These values will be stored in the database. Ideally the set of _authorizations_ are static so I guess it couldn't hurt to create constants for each, but then that would be one more thing to maintain when the set changes. Adding these constants can be done when we write the code to enforce the priviliges if needed. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40373/#review106907 ----------------------------------------------------------- On Nov. 17, 2015, 12:40 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40373/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 12:40 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and > Sumit Mohanty. > > > Bugs: AMBARI-13916 > https://issues.apache.org/jira/browse/AMBARI-13916 > > > Repository: ambari > > > Description > ------- > > Create API entry points for getting authorization information. > > The following entry points need to be created: > ``` > GET /api/v1/authorizations > GET /api/v1/permissions/:PERMISSION_ID/authorizations > GET /api/v1/users/:USERNAME/authorizations > ``` > > The following entry points need to be updated to supply more information: > ``` > GET /api/v1/permissions/:PERMISSION_ID > ``` > > # Note: The data layer is stubbed out and left for implementation in > AMBARI-13865 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/PermissionResourceDefinition.java > 56127b9 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > e7bbec4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PermissionService.java > 594caba > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RoleAuthorizationService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java > 05ee6b1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 0310fdc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > fbbc7c8 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/PermissionResourceDefinitionTest.java > 0ad3b47 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java > 081a6eb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java > ebe9b93 > > Diff: https://reviews.apache.org/r/40373/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PASSED > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
