----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42377/#review115090 -----------------------------------------------------------
ambari-web/app/controllers/main/host/combo_search_box.js (lines 30 - 32) <https://reviews.apache.org/r/42377/#comment175951> It should be possible to externalize this to Em.I18n.translations with calculated query, count and facet/facets as parameters ambari-web/app/controllers/main/host/combo_search_box.js (lines 38 - 41) <https://reviews.apache.org/r/42377/#comment175952> lets declare constant numbers as variables with relevant names having constant values. ambari-web/app/controllers/main/host/combo_search_box.js (lines 73 - 76) <https://reviews.apache.org/r/42377/#comment175957> Lets externalize the stack name references to messages.js. It will be helpful for renaming the stack names by simply swapping messages.js on build time when required. ambari-web/app/controllers/main/host/combo_search_box.js (lines 81 - 87) <https://reviews.apache.org/r/42377/#comment175954> We already have most of these string literals externalized in Em.I18n.translations. Please use them ambari-web/app/controllers/main/host/combo_search_box.js (lines 118 - 122) <https://reviews.apache.org/r/42377/#comment175955> We already have most of these string literals externalized in Em.I18n.translations. Please use them - Jaimin Jetly On Jan. 18, 2016, 9:13 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42377/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9:13 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-14700 > https://issues.apache.org/jira/browse/AMBARI-14700 > > > Repository: ambari > > > Description > ------- > > Refactor usage of visualsearch.js. Relocate loading related code to > controller. Add an exapmle flow for on demand value loading when creating > filter. > > > Diffs > ----- > > ambari-web/app/controllers.js 5f3f841 > ambari-web/app/controllers/main/host/combo_search_box.js PRE-CREATION > ambari-web/app/routes/main.js 70714b9 > ambari-web/app/templates/main/host.hbs 1c575a9 > ambari-web/app/views/main/host/combo_search_box.js 927a540 > > Diff: https://reviews.apache.org/r/42377/diff/ > > > Testing > ------- > > Manually tested on live cluster, All unit tests passed. > 23097 tests complete (17 seconds) > 165 tests pending > > > Thanks, > > Richard Zang > >
