----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42377/#review115702 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Jan. 20, 2016, 10:50 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42377/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 10:50 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-14700 > https://issues.apache.org/jira/browse/AMBARI-14700 > > > Repository: ambari > > > Description > ------- > > Refactor usage of visualsearch.js. Relocate loading related code to > controller. Add an exapmle flow for on demand value loading when creating > filter. > > > Diffs > ----- > > ambari-web/app/controllers.js 5f3f841 > ambari-web/app/controllers/main/host/combo_search_box.js PRE-CREATION > ambari-web/app/routes/main.js 70714b9 > ambari-web/app/templates/main/host.hbs 1c575a9 > ambari-web/app/views/main/host/combo_search_box.js 927a540 > > Diff: https://reviews.apache.org/r/42377/diff/ > > > Testing > ------- > > Manually tested on live cluster, All unit tests passed. > 23097 tests complete (17 seconds) > 165 tests pending > > > Thanks, > > Richard Zang > >
