----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42723/#review116373 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java (line 48) <https://reviews.apache.org/r/42723/#comment177415> Why inject the injector? You can inject the Configiration object instance. ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java (line 93) <https://reviews.apache.org/r/42723/#comment177416> File.exists checks for the existance of a file, not weather the user/process has access to it. Maybe you want to give detailed error messages - one if the file does not exist and one if the file cannot be read. - Robert Levas On Jan. 25, 2016, 11:47 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42723/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 11:47 a.m.) > > > Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, Sumit Gupta, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-14791 > https://issues.apache.org/jira/browse/AMBARI-14791 > > > Repository: ambari > > > Description > ------- > > Implement ambari JAAS configuration check during server startup. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 4120f34 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 43e2dac > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 823ac8a > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java > PRE-CREATION > ambari-server/src/main/python/ambari_server/serverConfiguration.py d5b9e86 > ambari-server/src/main/python/ambari_server/setupSecurity.py 89ea46c > > ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42723/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
