> On Янв. 26, 2016, 4:49 п.п., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java,
> > line 93
> > <https://reviews.apache.org/r/42723/diff/1/?file=1219412#file1219412line93>
> >
> > File.exists checks for the existance of a file, not weather the
> > user/process has access to it. Maybe you want to give detailed error
> > messages - one if the file does not exist and one if the file cannot be
> > read.
Despite of javadoc
* * @return true if the keytab file exists; false otherwise.
keytab.exists() checks the read access, I've made some experiments.
Nevertheless, I'll fix this to not to rely on undocumented functionallity.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42723/#review116373
-----------------------------------------------------------
On Янв. 25, 2016, 4:47 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42723/
> -----------------------------------------------------------
>
> (Updated Янв. 25, 2016, 4:47 п.п.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, Sumit Gupta,
> and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-14791
> https://issues.apache.org/jira/browse/AMBARI-14791
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Implement ambari JAAS configuration check during server startup.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 4120f34
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
> 43e2dac
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> 823ac8a
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java
> PRE-CREATION
> ambari-server/src/main/python/ambari_server/serverConfiguration.py d5b9e86
> ambari-server/src/main/python/ambari_server/setupSecurity.py 89ea46c
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42723/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
