----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43125/#review117535 -----------------------------------------------------------
Awesome, great to see this! ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 60) <https://reviews.apache.org/r/43125/#comment178736> Will need to test this with ambari agent running as non-root. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (line 388) <https://reviews.apache.org/r/43125/#comment178739> Why not put these in a list and just iterate over them? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 21) <https://reviews.apache.org/r/43125/#comment178740> Use explicit import instead of * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 26) <https://reviews.apache.org/r/43125/#comment178744> In a kerberized environment, will need to kinit. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 31) <https://reviews.apache.org/r/43125/#comment178741> Will eventually need to pick this up from a different location. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 32) <https://reviews.apache.org/r/43125/#comment178742> May need to create /usr/share/grafana/public/app/plugins/datasource if it doesn't exist. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 44) <https://reviews.apache.org/r/43125/#comment178743> Should have "/usr/sbin/ambari-metrics-grafana" as a variable - Alejandro Fernandez On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43125/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 12:49 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-14892 > https://issues.apache.org/jira/browse/AMBARI-14892 > > > Repository: ambari > > > Description > ------- > > Add a MASTER component called Grafana to AMS service. > > Include install and start/stop/status scripts for the grafana server. > > Config Management for Ambari Metrics - Grafana also part of this patch. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > 48469df > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 8fdf4ba > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > a1de919 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > 59466ad > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py > d446baa > > Diff: https://reviews.apache.org/r/43125/diff/ > > > Testing > ------- > > Manual testing done. > > > Thanks, > > Aravindan Vijayan > >
