> On Feb. 3, 2016, 1 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py,
> >  line 31
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230272#file1230272line31>
> >
> >     Will eventually need to pick this up from a different location.

Just an INITIAL PATCH that I used to test with. The Execute statements in 
install will not be there. We will be installing through usual rpm 
mechanism(another bug), and will be calling install.packages()


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117535
-----------------------------------------------------------


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  48469df 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  8fdf4ba 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  a1de919 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
>  59466ad 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to