> On Лют. 8, 2016, 6:47 після полудня, Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java, > > line 139 > > <https://reviews.apache.org/r/43266/diff/2/?file=1237019#file1237019line139> > > > > Does this query work on all DB types? I tried it on postgres and it was > > ok.
yes it should work for all db's, because i've used only basic sql syntax. > On Лют. 8, 2016, 6:47 після полудня, Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari-server.py, line 529 > > <https://reviews.apache.org/r/43266/diff/2/?file=1237020#file1237020line529> > > > > Can we always call check-database on startup? > > Even if it fails, Ambari Server should be allowed to start. Not sure it's a good idea. This check will become bigger and bigger, it will take some time for real production clusters, so i think it will be better to keep it like separate functionality with separate call. And as of now it's not tested enough, so we will take a look how it work in practice(release) and then we will decide to add it to start process or not. > On Лют. 8, 2016, 6:47 після полудня, Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java, > > line 233 > > <https://reviews.apache.org/r/43266/diff/2/?file=1237019#file1237019line233> > > > > We can actually make a stronger assertion here> > > Each tuple is uniquely identified by <service_name, component_name, > > host_id> > > > > We can ensure that this number is also equal, > > > > select count(*) FROM hostcomponentstate hcs JOIN > > hostcomponentdesiredstate hcds ON hcs.service_name = hcds.service_name AND > > hcs.component_name = hcds.component_name AND hcs.host_id = hcds.host_id; Will check and update if it's ok - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43266/#review118264 ----------------------------------------------------------- On Лют. 6, 2016, 6:43 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43266/ > ----------------------------------------------------------- > > (Updated Лют. 6, 2016, 6:43 після полудня) > > > Review request for Ambari, Alejandro Fernandez and Myroslav Papirkovskyy. > > > Bugs: AMBARI-14948 > https://issues.apache.org/jira/browse/AMBARI-14948 > > > Repository: ambari > > > Description > ------- > > Command line utility to find inconsistencies in configs > Services without configs > Configs without services > relationship between clusterconfig, serviceconfigmapping, and > clusterconfigmapping > Do outter joins and find missing configs > At least one should be selected for config type, compare known config types > vs expected in the stack, versions are incremental > > > Diffs > ----- > > ambari-server/sbin/ambari-server 47e2926 > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari-server.py 8be79a5 > ambari-server/src/main/python/ambari_server/checkDatabase.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 686ac9a > > Diff: https://reviews.apache.org/r/43266/diff/ > > > Testing > ------- > > Will add tests later > > > Thanks, > > Vitalyi Brodetskyi > >
