----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43266/#review118729 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 222) <https://reviews.apache.org/r/43266/#comment180029> DatabaseChecker::checkDBConsistency() does the same check. ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 282) <https://reviews.apache.org/r/43266/#comment180031> DatabaseChecker::checkDBConfigsConsistency() does a similar check. ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 292) <https://reviews.apache.org/r/43266/#comment180032> The third patch in https://reviews.apache.org/r/43405 has a check for all versions in clusterconfigmapping since the missing version causes NPE in ClusterImpl::getDesiredConfigs(). That review no longer has the DatabaseChecker.java change. You may want to consider moving that check here. - Nahappan Somasundaram On Feb. 9, 2016, 9:08 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43266/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 9:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Myroslav Papirkovskyy. > > > Bugs: AMBARI-14948 > https://issues.apache.org/jira/browse/AMBARI-14948 > > > Repository: ambari > > > Description > ------- > > Command line utility to find inconsistencies in configs > Services without configs > Configs without services > relationship between clusterconfig, serviceconfigmapping, and > clusterconfigmapping > Do outter joins and find missing configs > At least one should be selected for config type, compare known config types > vs expected in the stack, versions are incremental > > > Diffs > ----- > > ambari-server/sbin/ambari-server 47e2926 > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari-server.py 8be79a5 > ambari-server/src/main/python/ambari_server/checkDatabase.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 686ac9a > > Diff: https://reviews.apache.org/r/43266/diff/ > > > Testing > ------- > > Will add tests later > > > Thanks, > > Vitalyi Brodetskyi > >
