----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43425/#review118858 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java (line 619) <https://reviews.apache.org/r/43425/#comment180165> If we're in an upgrade, why not FAILED? If NOT in an upgrade, then yes, VERSION_MISMATCH. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 837 - 839) <https://reviews.apache.org/r/43425/#comment180166> Actually, we'll determine this from the repo_version entry. We can discuss. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 1167 - 1168) <https://reviews.apache.org/r/43425/#comment180167> Use an Entry<Service, Set<ServiceComponent>> iterator here. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 1174) <https://reviews.apache.org/r/43425/#comment180168> This should be in the isVersionAdvertised() block, and should anything not advertising its version be marked with UNKNOWN? ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java (line 211) <https://reviews.apache.org/r/43425/#comment180170> FAILED still seems valid in RU/EU case ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java (line 145) <https://reviews.apache.org/r/43425/#comment180171> Failed? - Nate Cole On Feb. 10, 2016, 1:55 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43425/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 1:55 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-14996 > https://issues.apache.org/jira/browse/AMBARI-14996 > > > Repository: ambari > > > Description > ------- > > When performing an upgrade, we need to specify that a component's desired > version is getting changed. > > Going to open additional jiras for TODOs in code > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 210fe17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > db8c079 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java > ee65d3d > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 74d4f4b > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java > 3a11f38 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > f92f645 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > d2d1b42 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 561350b > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > 7803045 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > f1e8d62 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 4afc857 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java > ced1dd3 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 92828af > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java > 1c36143 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java > ae05a6b > > ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java > 071c6f0 > > Diff: https://reviews.apache.org/r/43425/diff/ > > > Testing > ------- > > Pending E2E RU/EU upgrades/downgrades on live cluster > > Did not work on unit tests yet > > > Thanks, > > Dmitro Lisnichenko > >
