> On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java, > > line 145 > > <https://reviews.apache.org/r/43425/diff/2/?file=1239691#file1239691line145> > > > > Failed?
I was in doubt regarding removing FAILED state for host components, but decided to follow agreed component version design google doc. I tried to minimize host component version handling required, but thinking once more keeping FAILED seems to be profitable in terms of clear component state Will add FAILED back. Let's discuss on call how/when FAILED state should be transitioned to other states > On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 1174 > > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line1174> > > > > This should be in the isVersionAdvertised() block, and should anything > > not advertising its version be marked with UNKNOWN? great catch. I was moving if out of internal loop, and accidentally left that out > On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 1167-1168 > > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line1167> > > > > Use an Entry<Service, Set<ServiceComponent>> iterator here. good idea > On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 837-839 > > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line837> > > > > Actually, we'll determine this from the repo_version entry. We can > > discuss. what do you mean? - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43425/#review118858 ----------------------------------------------------------- On Feb. 10, 2016, 8:55 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43425/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 8:55 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-14996 > https://issues.apache.org/jira/browse/AMBARI-14996 > > > Repository: ambari > > > Description > ------- > > When performing an upgrade, we need to specify that a component's desired > version is getting changed. > > Going to open additional jiras for TODOs in code > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 210fe17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > db8c079 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java > ee65d3d > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 74d4f4b > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java > 3a11f38 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > f92f645 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > d2d1b42 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 561350b > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > 7803045 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > f1e8d62 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 4afc857 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java > ced1dd3 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 92828af > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java > 1c36143 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java > ae05a6b > > ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java > 071c6f0 > > Diff: https://reviews.apache.org/r/43425/diff/ > > > Testing > ------- > > Pending E2E RU/EU upgrades/downgrades on live cluster > > Did not work on unit tests yet > > > Thanks, > > Dmitro Lisnichenko > >
