----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44048/#review120972 -----------------------------------------------------------
ambari-web/app/controllers/main/admin/service_auto_start.js (line 178) <https://reviews.apache.org/r/44048/#comment182527> I am thinking it should be 'recoveryEnabled'? ambari-web/app/messages.js (line 1466) <https://reviews.apache.org/r/44048/#comment182526> The value should use a placeholder like '{0} components enabled' instead of just suffixing. In other languages it could end up in the middle etc. ambari-web/app/utils/ajax/ajax.js <https://reviews.apache.org/r/44048/#comment182528> Are you sure this has to be removed? Multiple other calls still make use of same structure. - Srimanth Gunturi On Feb. 25, 2016, 11:12 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44048/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 11:12 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15193 > https://issues.apache.org/jira/browse/AMBARI-15193 > > > Repository: ambari > > > Description > ------- > > 1. Auto-Start Services, strong > 2. Left align the Auto-Start Services switch (so it’s next to the text) > 3. Auto-Start Services (remove the word Enabled) > 4. Stick with the harvey balls > 5. Add tool tip on harvey ball to help the user understand it better > 6. Add column titles Service | Component | Status > 7. Add Enable All | Disable All links for convenience > 8. Any component that is NOT installed, do not display that component > 9. The popup text changes > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/service_auto_start.js 4071292 > ambari-web/app/messages.js 2622043 > ambari-web/app/styles/application.less 4e2b5d1 > ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c > > ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs > PRE-CREATION > ambari-web/app/utils/ajax/ajax.js 3ccd01c > ambari-web/app/views.js 0d3e49b > ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js > cc910b8 > > ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/44048/diff/ > > > Testing > ------- > > Local ambari-web test passed. > 24315 tests complete (22 seconds) > 146 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
