> On Feb. 26, 2016, 9:57 p.m., Srimanth Gunturi wrote: > > ambari-web/app/controllers/main/admin/service_auto_start.js, line 179 > > <https://reviews.apache.org/r/44048/diff/1/?file=1271644#file1271644line179> > > > > I am thinking it should be 'recoveryEnabled'?
That's what I thought, too. But to be consistent with varables (e.g. service_name, component_name, display_name), I removed the bi-direction conversions. > On Feb. 26, 2016, 9:57 p.m., Srimanth Gunturi wrote: > > ambari-web/app/utils/ajax/ajax.js, line 2372 > > <https://reviews.apache.org/r/44048/diff/1/?file=1271649#file1271649line2372> > > > > Are you sure this has to be removed? Multiple other calls still make > > use of same structure. I used that according other calls. But this api is not accepting that. I have to strip it out. - Zhe (Joe) ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44048/#review120972 ----------------------------------------------------------- On Feb. 26, 2016, 10:21 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44048/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 10:21 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15193 > https://issues.apache.org/jira/browse/AMBARI-15193 > > > Repository: ambari > > > Description > ------- > > 1. Auto-Start Services, strong > 2. Left align the Auto-Start Services switch (so it’s next to the text) > 3. Auto-Start Services (remove the word Enabled) > 4. Stick with the harvey balls > 5. Add tool tip on harvey ball to help the user understand it better > 6. Add column titles Service | Component | Status > 7. Add Enable All | Disable All links for convenience > 8. Any component that is NOT installed, do not display that component > 9. The popup text changes > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/service_auto_start.js 4071292 > ambari-web/app/messages.js 1cefce2 > ambari-web/app/styles/application.less 75ceacc > ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c > > ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs > PRE-CREATION > ambari-web/app/utils/ajax/ajax.js f839e58 > ambari-web/app/views.js 18b43a8 > ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js > cc910b8 > > ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/44048/diff/ > > > Testing > ------- > > Local ambari-web test passed. > 24315 tests complete (22 seconds) > 146 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
