----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44127/#review121062 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-master.json (line 2) <https://reviews.apache.org/r/44127/#comment182655> There are two with id = null ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-nn.json (line 2) <https://reviews.apache.org/r/44127/#comment182656> second one with id = null ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-nm.json (line 2) <https://reviews.apache.org/r/44127/#comment182654> These ids have to be unique - I assume. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py (line 172) <https://reviews.apache.org/r/44127/#comment182653> Will it fail Grafana start? - Sumit Mohanty On Feb. 27, 2016, 2:38 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44127/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 2:38 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15214 > https://issues.apache.org/jira/browse/AMBARI-15214 > > > Repository: ambari > > > Description > ------- > > - On Grafana start check if dashboard exists and has same version as ambari > - Add tags to dashboard to indicate _builtin_ and version of ambari > - Re-create dashboard if there is a mismatch or newly added definition found > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-master.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-rs.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-dn.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-nn.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-apps.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-nm.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-overview.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-rm.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > d96309c > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > 37d403d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 58ff71c > > Diff: https://reviews.apache.org/r/44127/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 244 tests in 6.817s > > OK > ---------------------------------------------------------------------- > Total run:891 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sid Wagle > >
