> On Feb. 27, 2016, 4:32 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-master.json, > > line 2 > > <https://reviews.apache.org/r/44127/diff/1/?file=1272877#file1272877line2> > > > > There are two with id = null
Yea when we export from Grafana it will have some id, I am explicitly setting it to null on POST so this does not matter. > On Feb. 27, 2016, 4:32 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-nn.json, > > line 2 > > <https://reviews.apache.org/r/44127/diff/1/?file=1272880#file1272880line2> > > > > second one with id = null Same as above. > On Feb. 27, 2016, 4:32 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-nm.json, > > line 2 > > <https://reviews.apache.org/r/44127/diff/1/?file=1272882#file1272882line2> > > > > These ids have to be unique - I assume. Same as above. > On Feb. 27, 2016, 4:32 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py, > > line 210 > > <https://reviews.apache.org/r/44127/diff/1/?file=1272886#file1272886line210> > > > > Will it fail Grafana start? Yes, we will fail if Grafana API is not working. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44127/#review121062 ----------------------------------------------------------- On Feb. 27, 2016, 2:38 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44127/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 2:38 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15214 > https://issues.apache.org/jira/browse/AMBARI-15214 > > > Repository: ambari > > > Description > ------- > > - On Grafana start check if dashboard exists and has same version as ambari > - Add tags to dashboard to indicate _builtin_ and version of ambari > - Re-create dashboard if there is a mismatch or newly added definition found > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-master.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hbase-rs.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-dn.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-hdfs-nn.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-apps.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-nm.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-overview.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/grafana-yarn-rm.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > d96309c > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > 37d403d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 58ff71c > > Diff: https://reviews.apache.org/r/44127/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 244 tests in 6.817s > > OK > ---------------------------------------------------------------------- > Total run:891 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sid Wagle > >
