----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44328/#review121834 -----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java (lines 1468 - 1480) <https://reviews.apache.org/r/44328/#comment183671> allServiceConfigResponses size should be checked before checking each element in it. - Daniel Gergely On márc. 3, 2016, 11:57 de, Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44328/ > ----------------------------------------------------------- > > (Updated márc. 3, 2016, 11:57 de) > > > Review request for Ambari, Daniel Gergely, Laszlo Puskas, and Oliver Szabo. > > > Bugs: AMBARI-15280 > https://issues.apache.org/jira/browse/AMBARI-15280 > > > Repository: ambari > > > Description > ------- > > Exclude service config responses whith deleted config group from the logic > that determines which config version is the active one in a config group. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java > e86b768 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 784a2d4 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 5c4bf11 > > Diff: https://reviews.apache.org/r/44328/diff/ > > > Testing > ------- > > Manual testing: > 1. Create config group with override for any service. > 2. Remove group in manage config groups popup. > > After deleting the config group verified that it disappears from the config > group list. Also checked that > api/v1/clusters/cl1/configurations/service_config_versions doesn't return any > entry with is_current=true for service configs that belong to the deleted > config group. > > > Unit tests are running. > > > Thanks, > > Sebastian Toader > >
