-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44328/
-----------------------------------------------------------
(Updated March 3, 2016, 2:22 p.m.)
Review request for Ambari, Daniel Gergely, Laszlo Puskas, and Oliver Szabo.
Changes
-------
Fix "allServiceConfigResponses size should be checked before checking each
element in it."
Bugs: AMBARI-15280
https://issues.apache.org/jira/browse/AMBARI-15280
Repository: ambari
Description
-------
Exclude service config responses whith deleted config group from the logic that
determines which config version is the active one in a config group.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java
e86b768
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
784a2d4
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
5c4bf11
Diff: https://reviews.apache.org/r/44328/diff/
Testing (updated)
-------
Manual testing:
1. Create config group with override for any service.
2. Remove group in manage config groups popup.
After deleting the config group verified that it disappears from the config
group list. Also checked that
api/v1/clusters/cl1/configurations/service_config_versions doesn't return any
entry with is_current=true for service configs that belong to the deleted
config group.
Unit tests:
Tests run: 3478, Failures: 0, Errors: 0, Skipped: 34
Thanks,
Sebastian Toader
